Skip to content

Fix CompressedDataChunk splitting#3898

Open
samirromdhani wants to merge 5 commits into
mainfrom
fix/1619-compresseddoubledatachunksplit-does-not-always-give-optimal-results
Open

Fix CompressedDataChunk splitting#3898
samirromdhani wants to merge 5 commits into
mainfrom
fix/1619-compresseddoubledatachunksplit-does-not-always-give-optimal-results

Conversation

@samirromdhani
Copy link
Copy Markdown
Contributor

@samirromdhani samirromdhani commented May 4, 2026

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #1619

What kind of change does this PR introduce?

Bug fix
What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani changed the title Fix CompressedDataChunk does not always give optimal results Fix CompressedDataChunk splitting May 4, 2026
@samirromdhani samirromdhani force-pushed the fix/1619-compresseddoubledatachunksplit-does-not-always-give-optimal-results branch from afa320e to f123e7b Compare May 4, 2026 14:42
@samirromdhani samirromdhani self-assigned this May 4, 2026
@samirromdhani samirromdhani marked this pull request as ready for review May 4, 2026 14:44
@samirromdhani samirromdhani requested review from olperr1 and rolnico May 4, 2026 14:48
@samirromdhani samirromdhani marked this pull request as draft May 5, 2026 07:37
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

remove unnecessary stepLengths1 assign: case split index equal to stepLengths of step

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the fix/1619-compresseddoubledatachunksplit-does-not-always-give-optimal-results branch from f123e7b to 2bba559 Compare May 5, 2026 07:42
@samirromdhani samirromdhani marked this pull request as ready for review May 5, 2026 07:42
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani marked this pull request as draft May 11, 2026 15:11
@samirromdhani samirromdhani marked this pull request as ready for review May 11, 2026 15:13
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CompressedDoubleDataChunk.split() does not always give optimal results

2 participants