Skip to content

Conversation

@vidaldid-rte
Copy link
Contributor

@vidaldid-rte vidaldid-rte commented Nov 17, 2025

NOTE: still in draft. Need to be tested in other repos that provide default parameter implementations.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
LoadFlowProvider.getSpecificParameters does not set the default values of a LoadFlowDefaultParameterLoader

What is the new behavior (if this is a feature change)?

  • getSpecificParameters overrides the raw specific parameters with values from the LoadFlowDefaultParameterLoader if present
  • The getSpecificParameters with a PlatformConfig overrides the values that take into account the default loadflow parameter loader if present in the classpath

IMPORTANT: the loadFlowProvider implementations must rename getSpecificParameters to getRawSpscificParameters
See example in powsybl/powsybl-open-loadflow#1299

Additionally , tests have been updated:
to align default values of DummyExtension with the defautl of the provider
to cover the case of a String List parameter (wich is nullable, to reflect the case of OuterLoopNames in OpenLoadFlow)

Does this PR introduce a breaking change or deprecate an API?

  • [X ] Yes
  • [] No

LoadFlowProviders should now implement getRawSpecificParameters (new method) instead of getSpecificParameters.

getSpecificParameters is now meant to override values if a default loadflow parameter loader is available. The default implementation of the LoadFlowProvider interface honnors the contract and is based on getRawSpecifciParameters.

LoadFlowProvider impementation can just remname their old method getSpecificParameters to getRawSpecificParameters

Signed-off-by: Didier Vidal <[email protected]>
…otocol for providers modified (breaking change)

Signed-off-by: Didier Vidal <[email protected]>
@vidaldid-rte vidaldid-rte added the Breaking Change API is broken label Nov 17, 2025
@sonarqubecloud
Copy link

@vidaldid-rte vidaldid-rte changed the title [DRAFT] Add default parameter loader's values to specific parameters Add default parameter loader's values to specific parameters Nov 17, 2025
@vidaldid-rte vidaldid-rte marked this pull request as ready for review November 17, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants