Add default parameter loader's values to specific parameters #3656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



NOTE: still in draft. Need to be tested in other repos that provide default parameter implementations.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
LoadFlowProvider.getSpecificParameters does not set the default values of a LoadFlowDefaultParameterLoader
What is the new behavior (if this is a feature change)?
IMPORTANT: the loadFlowProvider implementations must rename getSpecificParameters to getRawSpscificParameters
See example in powsybl/powsybl-open-loadflow#1299
Additionally , tests have been updated:
to align default values of DummyExtension with the defautl of the provider
to cover the case of a String List parameter (wich is nullable, to reflect the case of OuterLoopNames in OpenLoadFlow)
Does this PR introduce a breaking change or deprecate an API?
LoadFlowProviders should now implement getRawSpecificParameters (new method) instead of getSpecificParameters.
getSpecificParameters is now meant to override values if a default loadflow parameter loader is available. The default implementation of the LoadFlowProvider interface honnors the contract and is based on getRawSpecifciParameters.
LoadFlowProvider impementation can just remname their old method getSpecificParameters to getRawSpecificParameters