Skip to content

Conversation

@marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Nov 11, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?

Unit tests demonstrating two use cases of the update method have been added.

In the first test, one EQ file and four SSH files, one for midnight (00:00), morning (08:00), afternoon (16:00), and end of day (24:00) are imported. The midnight SSH file is complete and contains data for all equipment. The remaining SSH files are incremental, including only changes relative to the previous SSH file. The entire process is carried out in four steps, using a single variant.

  • First step: The EQ file and the midnight SSH file are imported.
  • Second step: The network is partially updated by importing the morning SSH file.
  • Third step: The network is partially updated by importing the afternoon SSH file.
  • Fourth step: The network is partially updated by importing the end-of-day SSH file.

The property iidm.import.cgmes.use-previous-values-during-update must be set to true to fill in missing data in the incremental SSH files using previous values.

In the second test, one EQ file and four SSH files, for midnight (00:00), morning (08:00), afternoon (16:00), and end of day (24:00), are imported. All SSH files are complete and contain data for all equipment. The entire process is carried out in four steps, using four different variants, one for each SSH file.

  • First step: The EQ file and the midnight SSH file are imported using the InitialState variant.
  • Second step: The morning SSH file is imported using the update-08 variant.
  • Third step: The afternoon SSH file is imported using the update-16 variant.
  • Fourth step: The end-of-day SSH file is imported using the update-24 variant.

At the end of the process, the four snapshots are stored in memory in separate variants.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: marquesja1 <[email protected]>
@sonarqubecloud
Copy link

@cphili cphili self-requested a review November 19, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants