Export fictitious injections in CGMES #3637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…depending on its sign Signed-off-by: Coline Piloquet <[email protected]>
Signed-off-by: Coline Piloquet <[email protected]>
Signed-off-by: Coline Piloquet <[email protected]>
Signed-off-by: Coline Piloquet <[email protected]>
colineplqt
commented
Nov 13, 2025
Member
Author
There was a problem hiding this comment.
@rcourtier, I don't know where to put the tests, any suggestions?
Signed-off-by: Coline Piloquet <[email protected]>
# Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/EquipmentExport.java
Signed-off-by: Coline Piloquet <[email protected]>
Signed-off-by: Coline Piloquet <[email protected]>
...cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/StateVariablesExport.java
Outdated
Show resolved
Hide resolved
| for (Bus b : vl.getBusBreakerView().getBuses()) { | ||
| double p = b.getFictitiousP0(); | ||
| double q = b.getFictitiousQ0(); | ||
| if (Math.abs(p) != 0.0 || Math.abs(q) != 0.0) { |
Contributor
There was a problem hiding this comment.
Maybe
if (p != 0.0 || q != 0.0)
| for (Bus b : vl.getBusBreakerView().getBuses()) { | ||
| double p = b.getFictitiousP0(); | ||
| double q = b.getFictitiousQ0(); | ||
| if (Math.abs(p) != 0.0 || Math.abs(q) != 0.0) { |
Contributor
There was a problem hiding this comment.
Same here
if (p != 0.0 || q != 0.0)
| for (int node : nb.getNodes()) { | ||
| double p = nb.getFictitiousP0(node); | ||
| double q = nb.getFictitiousQ0(node); | ||
| if (Math.abs(p) != 0.0 || Math.abs(q) != 0.0) { |
Contributor
There was a problem hiding this comment.
Maybe
if (p != 0.0 || q != 0.0)
| for (Bus b : vl.getBusBreakerView().getBuses()) { | ||
| double p = b.getFictitiousP0(); | ||
| double q = b.getFictitiousQ0(); | ||
| if (Math.abs(p) != 0.0 || Math.abs(q) != 0.0) { |
Contributor
There was a problem hiding this comment.
Also here
if (p != 0.0 || q != 0.0)
| double p = nodeBreakerView.getFictitiousP0(node); | ||
| double q = nodeBreakerView.getFictitiousQ0(node); | ||
|
|
||
| if (Math.abs(p) != 0.0 || Math.abs(q) != 0.0) { |
Contributor
There was a problem hiding this comment.
maybe
if (p != 0.0 || q != 0.0)
| double p = bus.getFictitiousP0(); | ||
| double q = bus.getFictitiousQ0(); | ||
|
|
||
| if (Math.abs(p) != 0.0 || Math.abs(q) != 0.0) { |
Contributor
There was a problem hiding this comment.
Maybe
if (p != 0.0 || q != 0.0)
Signed-off-by: Coline Piloquet <[email protected]>
Signed-off-by: Coline Piloquet <[email protected]>
|
Signed-off-by: Coline Piloquet <[email protected]>
marqueslanauja
approved these changes
Nov 27, 2025
github-project-automation
bot
moved this from In Progress
to Approved
in Release 12/2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #3608