-
Notifications
You must be signed in to change notification settings - Fork 49
Replace univocity parsers with JSaPar for handling fixed-width files #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't think it is a good idea to replace a mature and robust CSV parser like univocity (even if avandonned it is still working very well and do not need any evolution) by a ramdom young library not really popular with only 2 releases. The risk to move is much greater that keeping univocity. |
There are more than 2 releases: if you look at the tags or on https://mvnrepository.com/artifact/org.tigris.jsapar/jsapar, you'll see more. I'll still do the performance comparison to know how this "new" lib works compared to univocity |
…parsing Signed-off-by: Nicolas Rol <[email protected]>
55e84c2 to
02a53bf
Compare
|
I did some tests to compare the performances of this version vs main. Each test consisted of importing an IEEE-CDF test file and then exporting the model. Each operation was performed 10000 times consecutively, and the results are based on the last 9950 draws.
Thanks to the change of dependency, we could have a major gain in performances. Note: exported files have changed a bit, but they are now closer to IEEE-CDF standard. The models created from the files are however unchanged. |
Signed-off-by: Nicolas Rol <[email protected]>
|
|
Replaced by #3660 |


Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Change of dependency
What is the current behavior?
PowSyBl uses univocity-parsers for handling fixed-width files (parsing and writing), but this lib is abandoned since 2021.
What is the new behavior (if this is a feature change)?
PowSyBl now uses JSaPar for handling fixed-width files.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: