Skip to content

Conversation

@Samridhi-98
Copy link

Description

  • Modified server/index.js
  • Deleted server/server.js

Resolved issue
Fixes #16

@Samridhi-98
Copy link
Author

@elit-altum @coditva please review my pr.

1 similar comment
@Samridhi-98
Copy link
Author

@elit-altum @coditva please review my pr.

@coditva
Copy link
Member

coditva commented Jan 30, 2022

@Samridhi-98 Thanks for sending in the PR. Changes look good. Will test it out and merge it. 🙂

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #56 (c81e5a5) into develop (bb0d6bf) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #56      +/-   ##
===========================================
- Coverage    79.35%   79.04%   -0.31%     
===========================================
  Files           18       17       -1     
  Lines          339      334       -5     
  Branches        65       65              
===========================================
- Hits           269      264       -5     
  Misses          70       70              
Impacted Files Coverage Δ
server/index.js 85.96% <0.00%> (-14.04%) ⬇️
server/server.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0d6bf...c81e5a5. Read the comment docs.

@coditva coditva self-assigned this Jan 30, 2022
Copy link
Contributor

@elit-altum elit-altum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks @Samridhi-98 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server/server.js and server/index.js do similar things

3 participants