-
Notifications
You must be signed in to change notification settings - Fork 15
fix: remove 'over-reaching' python Chat
features
#62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cpsievert
wants to merge
9
commits into
main
Choose a base branch
from
gut-py-chat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Chat
featuresChat
features
6cb91e4
to
0ffbada
Compare
This was referenced Aug 6, 2025
cpsievert
added a commit
to posit-dev/py-shiny
that referenced
this pull request
Aug 6, 2025
cpsievert
added a commit
to posit-dev/py-shiny
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the python
Chat
features that were deprecated in #91Removing these features will bring the chat feature-set of the R and Python packages closer together, and significantly simplifies the Python implementation.
For context, this
Chat
class predatesellmer
,chatlas
, andshinychat
. Since then, it's become more clear that these features "over-reach" into responsibilities of the AI framework (i.e., chatlas, LangChain, etc), and too tightly coupled UI with LLM state.For reference, here is the list:
Chat(messages=...)
was removed. Usechat.ui(messages=...)
instead.Chat(tokenizer=...)
was removed. This was only relevant for.messages(token_limits=...)
which was also removed..messages()
were removed. This reflects an overall change philosophy for maintaining the conversation history sent to the LLM --Chat
should no longer be responsible for maintaining it -- another stateful object (perhaps the one provided by chatlas, LangChain, etc.) should be used instead. That said,.messages()
is still useful if you want to access UI message state.transform_user_input
andtransform_assistant_response
decorators were removed. Instead, transformation of input/responses should be done manually and independently ofChat
..user_input(transform=...)
was also removed..set_user_message()
method was officially removed (in favor of.update_user_input()
)TODO