Fix Pydantic serialization warnings by adding discriminator to ActionInvocationMethod union #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unit tests were showing Pydantic serialization warnings like:
These warnings occur because Pydantic v2 has stricter handling of union types during serialization. When encountering the
ActionInvocationMethod
union type, Pydantic couldn't determine which specific variant to use, leading to serialization ambiguity.Solution
Converted the
ActionInvocationMethod
union to use Pydantic's discriminated union feature:Before:
After:
The discriminator uses the existing
type
field (e.g., "GITHUB", "WEBHOOK", "KAFKA") that each invocation method class already has as aLiteral
field. This helps Pydantic identify the correct variant during serialization without ambiguity.Changes
Annotated
import fromtyping
Discriminator
import frompydantic
ActionInvocationMethod
to use discriminated union patternTesting
This fix eliminates the serialization warnings while maintaining full backward compatibility.
Fixes #59.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.