Skip to content

Comments

Initial script to convert hapmap to zarr#852

Draft
jeromekelleher wants to merge 1 commit intopopsim-consortium:mainfrom
jeromekelleher:recombination-map-to-zarr
Draft

Initial script to convert hapmap to zarr#852
jeromekelleher wants to merge 1 commit intopopsim-consortium:mainfrom
jeromekelleher:recombination-map-to-zarr

Conversation

@jeromekelleher
Copy link
Member

A first pass at #851.

Opening the zarr and getting the recombination map now takes a fraction of a second, massively faster than parsing hapmap.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #852 (9cbad54) into main (7ee1b33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          55       55           
  Lines        2412     2412           
  Branches      285      285           
=======================================
  Hits         2390     2390           
  Misses         14       14           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee1b33...9cbad54. Read the comment docs.

@andrewkern
Copy link
Member

would we still store hapmap formatted files in AWS or would we push a new directory full of zarrs?

@jeromekelleher
Copy link
Member Author

Just push a new directory full of zarrs. We'd keep the old maps around forever, so that existing code won't break, but this would be a clean start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants