kube: fix quantityToInt64 dropping scale for fractional BinarySI#28969
Merged
Conversation
Contributor
|
From a quick look, the changes look good. But it looks like you didn't sign your PR, and we can't merge until you do. |
ceca262 to
de33b8a
Compare
danishprakash
left a comment
Member
There was a problem hiding this comment.
Overall looks good but could you also add an integration test? thanks
Signed-off-by: guillermodotn <guillerm0.n@outlook.es>
Contributor
Author
Added an integration test in |
danishprakash
approved these changes
Jun 19, 2026
danishprakash
left a comment
Member
There was a problem hiding this comment.
LGTM (have rerun what seemed to be unrelated failures)
249df98
into
podman-container-tools:main
224 of 232 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
AsDec().Unscaled()withQuantity.Value()inquantityToInt64(), which properly handles the decimal scale. Remove the now-unused error returns fromquantityToInt64andsetupContainerResources. Add unit tests for fractional BinarySI inputs.Fixes: #28789
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?