Repository navigation
fix: remove broken testimonial links - #775
Closed
Ubayed-Bin-Sufian wants to merge 1 commit into
Closed
Ubayed-Bin-Sufian wants to merge 1 commit into
Ubayed-Bin-Sufian wants to merge 1 commit into
Conversation
Signed-off-by: Ubayed Bin Sufian <ubayedbinsufian@gmail.com>
Ubayed-Bin-Sufian
force-pushed
the
fix/testimonial-links-725
branch
from
October 11, 2026 00:25
fc0edc8 to
8c4e32b
Compare
Contributor
|
@portgasdyamato is this part of your #784 ? |
Collaborator
|
@TomSweeneyRedHat added! |
Contributor
Author
There was a problem hiding this comment.
Closing this PR because PR #784 overlaps with part of this fix, specifically the removal of Shinya Yanagihara’s expired featuredlink.
Please ensure the final implementation also addresses Ananth Iyer’s broken testimonial URL. Since his testimonial content is being preserved, the component should handle a missing path by rendering the handle and date as plain text rather than creating empty or invalid links.
The complete fix should therefore:
- remove Shinya’s broken featured link;
- remove Ananth’s broken path;
- preserve Ananth’s testimonial content;
- avoid rendering invalid anchors when a testimonial has no URL.
Thanks for addressing this issue. This PR is being closed because the overlapping work is being handled in PR #784.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #725
Screenshot