-
Notifications
You must be signed in to change notification settings - Fork 163
Fix for Issue: https://github.com/pnp/pnpcore/pull/1688 when try to deploy empty sections from XML-Template #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…m XML-Template
|
I reverted "my fix" and got your code and it's working, the page opens in edit mode without the issue I reported. Thank you @czullu very much for this. |
|
We have a close error to this, after deploying page templates with sections and section colors and backgrounds, the template is not editable or usable after deploying from xml to the sites. How can i help to verify the problem if this is the same error? |
These fixs are not released yet, I had to debug and update my forks of PnP.Core and then the PnP.Framework and PnP.Powershell with czullu changes. |
Funny, thing, we do not have any empty sections (or better, the xml does not have any empty section in it). And if i open the deployed template on the destination site directly, i can see all elements. But if i try to create a new page from this template, i cant click the create button and the page template is locked by myself. Before using sections with formatting, the page template works... |
|
Maybe it's better to create "bug" to describe your issue better, for me, everything started from this #1685 and you can try to check if is there anything related! |
|
@DanielMisch sorry - everyone seems quite busy - that's why things not get merged. However i will see what if we can get the pull request merged. |
I'am fully aware of this game... features coming out at year's end like rain... hope the merge can happen soon :-) |
|
@czullu @PedroMordeP Is there a possible timeframe for this merge? |

The Issue with provisioning Empty sections from here pnp/pnpcore#1688 is on translation from XML back to PnP.Core. The EmptySections have been translated to CustomWebPart but they should not be added to Page-Model as we add EmptySections if we try to save Sections without webParts.
Other Solution would have been to create NewEmptySection() Methode to Page.cs in PnP.Core and then add a EmptySection-CanvasControl to Page-Model.
@PedroMordeP I was able to correctly provision your XML-Template with default PnP.Core and this fix in PnP.Framework