Skip to content

Conversation

@czullu
Copy link
Contributor

@czullu czullu commented Sep 26, 2025

The Issue with provisioning Empty sections from here pnp/pnpcore#1688 is on translation from XML back to PnP.Core. The EmptySections have been translated to CustomWebPart but they should not be added to Page-Model as we add EmptySections if we try to save Sections without webParts.

Other Solution would have been to create NewEmptySection() Methode to Page.cs in PnP.Core and then add a EmptySection-CanvasControl to Page-Model.

@PedroMordeP I was able to correctly provision your XML-Template with default PnP.Core and this fix in PnP.Framework

@PedroMordeP
Copy link
Contributor

PedroMordeP commented Sep 30, 2025

I reverted "my fix" and got your code and it's working, the page opens in edit mode without the issue I reported.

Thank you @czullu very much for this.

@DanielMisch
Copy link

We have a close error to this, after deploying page templates with sections and section colors and backgrounds, the template is not editable or usable after deploying from xml to the sites. How can i help to verify the problem if this is the same error?

@PedroMordeP
Copy link
Contributor

We have a close error to this, after deploying page templates with sections and section colors and backgrounds, the template is not editable or usable after deploying from xml to the sites. How can i help to verify the problem if this is the same error?

These fixs are not released yet, I had to debug and update my forks of PnP.Core and then the PnP.Framework and PnP.Powershell with czullu changes.
This way i have collected and deploy a template without issues related to the empty sections

@DanielMisch
Copy link

We have a close error to this, after deploying page templates with sections and section colors and backgrounds, the template is not editable or usable after deploying from xml to the sites. How can i help to verify the problem if this is the same error?

These fixs are not released yet, I had to debug and update my forks of PnP.Core and then the PnP.Framework and PnP.Powershell with czullu changes. This way i have collected and deploy a template without issues related to the empty sections

Funny, thing, we do not have any empty sections (or better, the xml does not have any empty section in it). And if i open the deployed template on the destination site directly, i can see all elements. But if i try to create a new page from this template, i cant click the create button and the page template is locked by myself. Before using sections with formatting, the page template works...

@PedroMordeP
Copy link
Contributor

PedroMordeP commented Nov 3, 2025

Maybe it's better to create "bug" to describe your issue better, for me, everything started from this #1685 and you can try to check if is there anything related!

@DanielMisch
Copy link

Yes, i thnk its related as i get this error:
image

@czullu
Copy link
Contributor Author

czullu commented Nov 3, 2025

@DanielMisch sorry - everyone seems quite busy - that's why things not get merged. However i will see what if we can get the pull request merged.
With my fixes (multiple for pnpcore and pnpframework as pnpframework builds on pnpcore) it should work again - at least i does for me. With the new features microsoft did release for pages we have the challenge to map this to existing old xml schema...

@DanielMisch
Copy link

@DanielMisch sorry - everyone seems quite busy - that's why things not get merged. However i will see what if we can get the pull request merged. With my fixes (multiple for pnpcore and pnpframework as pnpframework builds on pnpcore) it should work again - at least i does for me. With the new features microsoft did release for pages we have the challenge to map this to existing old xml schema...

I'am fully aware of this game... features coming out at year's end like rain... hope the merge can happen soon :-)

@DanielMisch
Copy link

@czullu @PedroMordeP Is there a possible timeframe for this merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants