Skip to content

RS/JX/Rule5-43-2022 #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: feature/ashrae-9012022
Choose a base branch
from
Open

RS/JX/Rule5-43-2022 #1782

wants to merge 5 commits into from

Conversation

Jiarongx-Xie
Copy link
Collaborator

@Jiarongx-Xie Jiarongx-Xie commented Jul 31, 2025 •
edited
Loading

This rule has not been tested.

jugonzal07 and others added 3 commits July 15, 2025 16:51
@jugonzal07
Made adjustments to rule test generation to allow for ASHRAE 90.1 202…
321bd3a 
…2 to be selectable as a rule set. There remains a place for work to add ASHRAE901 2022 software test results.
@jugonzal07
minor black formatting issue.
3204c7d
@Jiarongx-Xie
initial setup
531863e
@Jiarongx-Xie Jiarongx-Xie self-assigned this Jul 31, 2025
@Jiarongx-Xie Jiarongx-Xie marked this pull request as draft July 31, 2025 19:33
@Jiarongx-Xie Jiarongx-Xie marked this pull request as ready for review July 31, 2025 21:11
yunjoonjung-PNNL
yunjoonjung-PNNL approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@yunjoonjung-PNNL yunjoonjung-PNNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed only 5-43 rule file and left a few comments. Please double-check these. Thank you Jiarong!

@Jiarongx-Xie
Copy link
Collaborator Author

I've reviewed only 5-43 rule file and left a few comments. Please double-check these. Thank you Jiarong!

I have addressed all your comments. Thank you Yun Joon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjoonjung-PNNL yunjoonjung-PNNL yunjoonjung-PNNL approved these changes

@weilixu weilixu Awaiting requested review from weilixu

Assignees

@Jiarongx-Xie Jiarongx-Xie

Labels
ASHRAE90.1 2022 rule_definition section5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiarongx-Xie @yunjoonjung-PNNL @jugonzal07