Open
Conversation
Collaborator
|
Hello Jordan, I´m taking care of checking the PRS so I´ll be testing this feature, will get back to you this week. That being said, the new feature assumes that the user can have up to a 1000 clip boxes which implies 4 texture fetches per box, this can hurt the shader performance wise. |
Collaborator
|
Sorry I haven´t posted anything yet, this feature is being tested |
Collaborator
|
We've run prettier recently. It's highly recommended to first run "npm run format:write", commit and rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to support more Clip Boxes by passing them by DataTexture instead of a Uniform Matrix array. This allows us to greatly increase the number of possible clipping boxes while not having to worry about gl.MAX_VERTEX_UNIFORM_VECTORS.