Skip to content

init capacity #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

init capacity #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Assets/RTLTMPro/Scripts/Runtime/FastStringBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public void Substring(FastStringBuilder output, int start, int length) {
}

public override string ToString() {
StringBuilder sb = new StringBuilder();
StringBuilder sb = new StringBuilder(length * 2);
Copy link
Collaborator

@hk1ll3r hk1ll3r Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should set the capacity to the eventual length of the string which we could compute by replicating the surrogate pair logic in our code. 2*length is an upper bound and allocates twice as much memory as is needed in most cases.

for (int i = 0; i < length; i++) {
sb.Append(char.ConvertFromUtf32(array[i]));
}
Expand All @@ -170,10 +170,10 @@ public override string ToString() {

public string ToDebugString()
{
StringBuilder sb = new StringBuilder();
StringBuilder sb = new StringBuilder(length * 3);
Copy link
Collaborator

@hk1ll3r hk1ll3r Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not worry about performance of debug code.

for (int i = 0; i < length; i++)
{
sb.Append("\\");
sb.Append('\\');
sb.Append(array[i].ToString("X"));
}
return sb.ToString();
Expand Down