fix(webgpu): resolve v10 CI type errors - #3910
Open
krispya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both React 19.0.0 and latest CI jobs stop at typechecking because the WebGPU entry exports two distinct
NodeRecorddeclarations and a render-pipeline lifecycle test returns a plain object instead of a Three.js node.Share the generic
NodeRecorddeclaration between the store and node hooks, preserving existing import paths and generic usage. Update the lifecycle test to return real pass nodes and verify that the exact nodes reach the store.Validation:
pnpm run cipasses locally, including build, bundle/type verification, typechecking, lint, 641 passing tests (9 TODOs), coverage thresholds, and formatting.