fix: guard events.connect against null target - #3871
Open
ErfanBagheri404 wants to merge 1 commit into
Open
Conversation
The connect target is null when the canvas subtree is DOM-reparented (e.g. during a spring animation via appendChild between containers). Disconnect already guards via if(events.connected); mirror that for connect. Fixes pmndrs#3754.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
events.connect(target)doestarget.addEventListener(...)with no null guard.disconnectalready checksif (events.connected), butconnectdoes not.When a
<Canvas>subtree is DOM-reparented viaappendChildduring a spring animation, r3f callsevents.connect(eventSource)withtarget == null, crashing with:This happens 23+ times per fullscreen entry/exit with a common
Fullscreenablepattern.Fix
Add
if (!target) returnat the top of theconnectmethod inpackages/fiber/src/web/events.ts, matching the defensive style already used indisconnect.Fixes #3754