Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
things to finish:
pnpm run micro arrays/deopt.js)things to note:
traces like
--trace-optor--trace-deoptwill write to the logFile somewhat unpredictably. thus, in order to capture these outputs within their proper context I adopt a delimiter model. much of theutils/folder is simply creating good conventions around this to avoid parsing bugs.in this version i have commented out
--trace-optas i opted for traceLogger to instead for an optimization after the first bench in a set/catalog runs: https://github.com/pmndrs/koota/pull/168/files#diff-79e44628c4e8559e0e0592c1aa9b829df446fecc84d5659a4425ae99bef438ddR39-R43the thought process for this is what we really want to flag here is deopts. we could wait for the function to manually become hot and stable, but we wouldn't necessarily know when this would happen. and it doesn't seem like --trace-opt gives detailed output anyway - most of the logs from that will just give you the memory address and the only "reason" given is the function is now "hot & stable". i could have the html handle present these in a useful way - or at least a way that wasn't annoying - but really they are not that meaningful imo compared to a deopt.