refactor(text): hold the Three integration to third-party rigor - #61
Open
thejustinwalsh wants to merge 2 commits into
Open
refactor(text): hold the Three integration to third-party rigor#61thejustinwalsh wants to merge 2 commits into
thejustinwalsh wants to merge 2 commits into
Conversation
size-limit report 📦
|
thejustinwalsh
force-pushed
the
refactor/three-public-rigor
branch
2 times, most recently
from
August 11, 2026 23:33
0f9d33c to
cac54e4
Compare
thejustinwalsh
marked this pull request as ready for review
August 12, 2026 00:30
Three's modules import the ABI through the public core entry instead of reaching into generated/, and a scoped no-restricted-imports rule denies the three, tsl, and react surfaces any import from internal/ or generated/ — the first-party integrations consume exactly the surface a third party gets.
thejustinwalsh
force-pushed
the
refactor/three-public-rigor
branch
from
August 12, 2026 00:32
cac54e4 to
d487ab4
Compare
# Conflicts: # docs/packages/glyph.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-party rigor (D-249)
Three's modules import the ABI through the public core entry instead of reaching into
generated/, and a scopedno-restricted-importsrule denies the three, tsl, and react surfaces any import frominternal/orgenerated/— the first-party integrations consume exactly the surface a third party gets, and the boundary regresses loudly instead of silently.Stack created with GitHub Stacks CLI • Give Feedback 💬