Skip to content

Conversation

@rohnsha0
Copy link
Member

fixes #4155

@rohnsha0 rohnsha0 requested a review from ericof April 24, 2025 07:33
@mister-roboto
Copy link

@rohnsha0 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@rohnsha0
Copy link
Member Author

@jenkins-plone-org please run jobs

@rohnsha0
Copy link
Member Author

@jenkins-plone-org please run jobs

@ericof
Copy link
Member

ericof commented Apr 24, 2025

@rohnsha0 Thank you for tackling this. I will have some additional comments (because I already implemented this in another project) to you soon.

@rohnsha0
Copy link
Member Author

@rohnsha0 Thank you for tackling this. I will have some additional comments (because I already implemented this in another project) to you soon.

AH, waiting for it!

@rohnsha0 rohnsha0 linked an issue Apr 26, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom base profiles in MigrationTool without subclassing

4 participants