Preamble: continue if .pex is outside a Please repo #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_plz_bin_path` is too aggressive about erroring if the preamble configuration contains an interpreter path prepended with `$PLZ_BIN_PATH` and `argv[0]` is located outside a Please repo - this shouldn't be an error case if there are other, valid interpreters in the list that could be executed. Don't immediately emit a fatal error if `$PLZ_BIN_PATH` can't be resolved - instead, just omit interpreter paths prepended with `$PLZ_BIN_PATH` from the search path and continue, only erroring if no interpreter paths could be resolved.
kavya-chopra
approved these changes
Dec 4, 2025
toastwaffle
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_plz_bin_pathis too aggressive about erroring if the preamble configuration contains an interpreter path prepended with$PLZ_BIN_PATHandargv[0]is located outside a Please repo - this shouldn't be an error case if there are other, valid interpreters in the list that could be executed. Don't immediately emit a fatal error if$PLZ_BIN_PATHcan't be resolved - instead, just omit interpreter paths prepended with$PLZ_BIN_PATHfrom the search path and continue, only erroring if no interpreter paths could be resolved.