Remove InterpreterOptions plugin configuration option
#288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
approved these changes
Dec 3, 2025
The documentation for the `InterpreterOptions` plugin configuration option is ambiguous - it implies the options within are used by Python while the .pex is being built (e.g. while compiling bytecode), but actually they're embedded in the .pex and used at run time. Now they aren't used at all: this functionality is instead provided by `RuntimeInterpreterArgs`. Remove `InterpreterOptions`, since it is obsolete. Also tidy up some of the variable names in the Python build defs to make it explicit that the arguments in `RuntimeInterpreterArgs` are in fact passed to Python at run time.
chrisnovakovic
force-pushed
the
defaultinterpreterargs
branch
from
f9a0dab to
6a7fc77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
InterpreterOptionsplugin configuration option is ambiguous - it implies the options within are used by Python while the .pex is being built (e.g. while compiling bytecode), but actually they're embedded in the .pex and used at run time. Now they aren't used at all: this functionality is instead provided byRuntimeInterpreterArgs.Remove
InterpreterOptions, since it is obsolete. Also tidy up some of the variable names in the Python build defs to make it explicit that the arguments inRuntimeInterpreterArgsare in fact passed to Python at run time.