Add python_toolchain #238
Open
Add python_toolchain #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
go_toolchainandjava_toolchain, let Python get in on the fun too.This uses python-build-standalone which seems well supported & widely used by a bunch of other projects.
It doesn't seem particularly hard apart from matching up how we name os's / architectures etc to how they do it. Can be extended easily enough in future if someone needs a different one.
There's already a hardcoded single-arch version of this in this repo for testing, so have swapped that over; the GHA pre-merge build should show it works (or that I have made some silly mistake)