Prioritise headers provided by dependencies over system headers #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header directories collected from direct dependencies are placed in the header search path using `-isystem`, which allows them to be preempted by the compiler toolchain injecting its own `-I` options into the argument list. This causes build failures if the compiler toolchain's injected directories contain a header with the same file name as one provided by a dependency but a different API; in the worst case, it can cause compilation to silently succeed but trigger unexpected run-time behaviour. Add header directories for dependencies to the search path via `-I`, but make sure they appear in the argument list after the options added by `compiler_flags` so they can be overridden if necessary. Fixes please-build#96.
toastwaffle
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header directories collected from direct dependencies are placed in the header search path using
-isystem, which allows them to be preempted by the compiler toolchain injecting its own-Ioptions into the argument list. This causes build failures if the compiler toolchain's injected directories contain a header with the same file name as one provided by a dependency but a different API; in the worst case, it can cause compilation to silently succeed but trigger unexpected run-time behaviour.Add header directories for dependencies to the search path via
-I, but make sure they appear in the argument list after the options added bycompiler_flagsso they can be overridden if necessary.Fixes #96.