Skip to content

Conversation

@chrisnovakovic
Copy link
Contributor

The union of plz test -i test,cc and plz test -i test,go isn't the set of tests in the repo: it excludes the //test:static_test e2e test and the //test/strip:strip_test and //test/binary:cc_binary_test gentests. Consider the set of C/C++ tests to be the inversion of the set of tests triggered by plz test -i test,go (in other words, plz test -e test,go) so that these three tests are correctly considered to be C/C++ tests.

The union of `plz test -i test,cc` and `plz test -i test,go` isn't the
set of tests in the repo: it excludes the `//test:static_test` e2e test
and the `//test/strip:strip_test` and `//test/binary:cc_binary_test`
`gentest`s. Consider the set of C/C++ tests to be the inversion of the
set of tests triggered by `plz test -i test,go` (in other words, `plz
test -e test,go`) so that these three tests are correctly considered to
be C/C++ tests.
@chrisnovakovic
Copy link
Contributor Author

This is now doing the right thing.

C/C++ tests:

Run ./pleasew test -e test,go --keep_going --log_file plz-out/log/test.log
Downloading Please 17.19.1 to /home/runner/.please/17.19.1...
Should be good to go now, running plz...
//test:cc_deps_test 2 tests run in 3ms; 2 passed
//test:cc_multisrc_test 2 tests run in 4ms; 2 passed
//test:cc_multisrc_test_2 2 tests run in 6ms; 2 passed
//test:static_test 1 test run in 2.98s; 1 passed
//test/binary:cc_binary_test 1 test run in 4ms; 1 passed
//test/deps:deps_test 1 test run in 3ms; 1 passed
//test/labels:lib_test 1 test run in 5ms; 1 passed
//test/modules:interdependent_modules_test 2 tests run in 4ms; 2 passed
//test/so:so_test 1 test run in 3ms; 1 passed
//test/strip:strip_test 1 test run in 296ms; 1 passed
11 test targets and 14 tests run; 14 passed.
Total time: 18.95s real, 3.31s compute.

Go (please_cc) tests:

Run ./pleasew test -i test,go --keep_going --log_file plz-out/log/test.log
Downloading Please 17.19.1 to /home/runner/.please/17.19.1...
Should be good to go now, running plz...
//tools/please_cc/cctool:cctool_test 644 tests run in 347ms; 644 passed
//tools/please_cc/expr:expr_test 252 tests run in 15ms; 252 passed
2 test targets and 896 tests run; 896 passed.
Total time: 33.51s real, 360ms compute.

@chrisnovakovic chrisnovakovic merged commit bf51e69 into please-build:master Nov 6, 2025
28 checks passed
@chrisnovakovic chrisnovakovic deleted the test-cc-exclude-go branch November 6, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants