strip_test: build executables with debug symbols
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Darwin, it seems that the plugin's default compiler and linker flags generate executables that are already pretty stripped, to the extent that `-Wl,-S -Wl,-x` doesn't do anything meaningful to all of them (e.g. the stripped and unstripped shared objects have identical file sizes and contain the same number of symbols). Guarantee that the linker has symbols to strip by emitting debug symbols in the generated binaries; that way, the tests can ensure that the unstripped executables contain them, and the stripped ones don't. This also removes the run-time dependency on `file(1)`, which might not be present (e.g. on Alpine); `nm(1)` is part of both GNU binutils and LLVM, and is therefore much more likely to be installed if GCC or Clang are installed.
toastwaffle
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin, it seems that the plugin's default compiler and linker flags generate executables that are already pretty stripped, to the extent that
-Wl,-S -Wl,-xdoesn't do anything meaningful to all of them (e.g. the stripped and unstripped shared objects have identical file sizes and contain the same number of symbols). Guarantee that the linker has symbols to strip by emitting debug symbols; that way, the tests can ensure that the unstripped executables contain them, and the stripped ones don't.This also removes the run-time dependency on
file(1), which might not be present (e.g. on Alpine);nm(1)is part of both GNU binutils and LLVM, and is therefore much more likely to be installed if GCC or Clang are installed.