Replace Python-based shared object test with a C++-only version #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shared object test has dependencies on both Python and pkg-config (in order to locate libpython and Python's headers). It dates back to a time when the C/C++ and Python rules were both part of the main Please repo, but now that they live in separate plugin repos, importing the python-rules plugin (and expecting Python and pkg-config to be installed system-wide) is excessive for the sake of a single test that doesn't strictly require Python to prove that cc-rules' dynamic linking functionality works as expected. Eliminate libpython from the ABI between the shared object and test binary. What remains is enough to prove that cc-rules is generating valid shared libraies that are loadable at run-time by dynamically-linked binaries.
toastwaffle
approved these changes
Sep 25, 2025
| #include "dolphin.hpp" | ||
|
|
||
| std::string Dolphin::depart() { | ||
| return "So long, and thanks for all the fish"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared object test has dependencies on both Python and pkg-config (in order to locate libpython and Python's headers). It dates back to a time when the C/C++ and Python rules were both part of the main Please repo, but now that they live in separate plugin repos, importing the python-rules plugin (and expecting Python and pkg-config to be installed system-wide) is excessive for the sake of a single test that doesn't strictly require Python to prove that cc-rules' dynamic linking functionality works as expected.
Eliminate libpython from the ABI between the shared object and test binary. What remains is enough to prove that cc-rules is generating valid shared libraries that are loadable at run-time by dynamically-linked binaries.