Skip to content

Add support for heroku 24 stack #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add support for heroku 24 stack #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94f793
Add support for heroku 24 stack
jasonsbrooks Aug 5, 2024
6e38655
Update compile
jasonsbrooks Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bin/compile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ topic() {
install_system_deps() {
topic "Installing System Dependencies"

APT_BUILDPACK="https://github.com/heroku/heroku-buildpack-apt"
APT_BUILDPACK="https://github.com/KinnTech/heroku-buildpack-apt"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

local buildpack_tmpdir=$(mktemp -d)
cd $buildpack_tmpdir && git clone $APT_BUILDPACK .

Expand Down Expand Up @@ -88,10 +88,15 @@ EOF
"heroku-22")
cat << EOF >>$build_tmpdir/Aptfile
libvpx7
EOF
;;
"heroku-24")
cat << EOF >>$build_tmpdir/Aptfile
libvpx9
EOF
;;
*)
error "STACK must be 'heroku-18', 'heroku-20', or 'heroku-22'"
error "STACK must be 'heroku-18', 'heroku-20', 'heroku-22', or 'heroku-24'"
esac

local cache_tmpdir=$(mktemp -d)
Expand Down