Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements critical fixes for the new installer to ensure proper system installation and stability. The changes address issues with filesystem operations, UUID management, and boot configuration, while also preventing unwanted writes during installation.
Changes:
- Prevents writes to /var/log and /var/lib during installation by mounting them as tmpfs
- Updates UUID regeneration to handle both partition and filesystem UUIDs for ext4
- Adds rate limiting to disk cloning operations to prevent system instability
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rootfs/usr/libexec/playtron/os-install | Implements UUID regeneration, rate limiting, machine-id reset, and boot priority configuration |
| config.toml | Adds tmpfs mount configurations for /var/log and /var/lib during installation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LukeShortCloud
left a comment
LukeShortCloud
left a comment
There was a problem hiding this comment.
The new changes look good to me. Thanks!
|
Do we still need a forked bootc-image-builder container on x86? Our Arm builds are using the upstream container. https://github.com/playtron-os/gameos/blob/unstable/1.2.0.11/Taskfile.yml#L169 |
| else | ||
| btrfs filesystem resize max /var | ||
| fi | ||
| resize2fs ${root_device}${root_partition_number} |
There was a problem hiding this comment.
This works for /dev/sda devices but not /dev/mmcblk or /dev/nvme.
For example:
+ echo resize2fs /dev/nvme0n13
resize2fs /dev/nvme0n13
where /dev/nvme0n13 should be /dev/nvme0n1p3 (there is a "p" for partition).
You should probably use:
resize2fs ${root_partition}
There was a problem hiding this comment.
Pushed a fix for this, thanks.
alkazar
force-pushed
the
new-installer-fixes
branch
from
0cfd733 to
0bbdc7d
Compare
This PR includes various fixes and optimizations for the new installer.
Due to the changes in 42a79b9 this PR cannot be merged without breaking builds based on btrfs. So we need to wait until after the next release which is expected to be the last btrfs release. For this reason, I have marked this PR as Draft.