Skip to content

add render-time and async node error recovery pattern #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmarmer wants to merge 35 commits into
base: error-controller
Choose a base branch
from
+5,718 −388

ignore jvm testutils in codecov report

107cbfe
Select commit
Loading
Failed to load commit list.
Open

add render-time and async node error recovery pattern #802

ignore jvm testutils in codecov report
107cbfe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 26, 2026 in 1s

86.36% (+0.33%) compared to 07bcf2a

View this Pull Request on Codecov

86.36% (+0.33%) compared to 07bcf2a

Details

Codecov Report

❌ Patch coverage is 94.38356% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.36%. Comparing base (07bcf2a) to head (107cbfe).

Files with missing lines Patch % Lines
.../com/intuit/playerui/core/error/ErrorController.kt 66.66% 2 Missing and 5 partials ⚠️
plugins/async-node/core/src/index.ts 95.39% 7 Missing ⚠️
...e/serialization/serializers/ThrowableSerializer.kt 76.00% 3 Missing and 3 partials ⚠️
core/player/src/view/resolver/index.ts 93.65% 4 Missing ⚠️
react/player/src/player.tsx 95.87% 4 Missing ⚠️
.../com/intuit/playerui/core/player/HeadlessPlayer.kt 0.00% 3 Missing ⚠️
...e-assets/core/src/plugins/error-recovery-plugin.ts 90.32% 3 Missing ⚠️
core/player/src/controllers/view/controller.ts 87.50% 2 Missing ⚠️
...gins/async-node/core/src/utils/getNodeFromError.ts 91.30% 2 Missing ⚠️
core/player/src/controllers/error/controller.ts 95.83% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@                 Coverage Diff                  @@
##           error-controller     #802      +/-   ##
====================================================
+ Coverage             86.02%   86.36%   +0.33%     
====================================================
  Files                   513      512       -1     
  Lines                 23566    24020     +454     
  Branches               2703     2828     +125     
====================================================
+ Hits                  20272    20744     +472     
+ Misses                 2956     2942      -14     
+ Partials                338      334       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov