Update maxmemory policy descriptions #4788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The valkey (and redis) documentation talks about an expire field being true/false. There is no such thing. I suspect this got mixed up with the Drupal redis module, which stores a such a flag as part of it's cache items.
What valkey/redis does have is a TTL, set with EXPIRE and read with TTL.
What's changed
Copy paste of the descriptions from the valkey docs which consistently use TTL instead of expire
Where are changes
Updates are for:
sites/platformtemplates)sites/upsuntemplates)