feat: add iframe support to SOM compiler#39
Merged
Conversation
Detect <iframe> elements during SOM compilation and expose them as ElementRole::Iframe with relevant attributes: - src: URL of embedded content - srcdoc: inline HTML content (has_srcdoc flag + preview) - name: frame name for targeting - sandbox: security restrictions - allow: permissions policy - width/height: dimensions This enables agents to understand embedded content boundaries without needing to fetch or execute iframe content. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ElementRole::Iframeto detect and represent<iframe>elements in SOM outputsrc,srcdoc,name,sandbox,allow,width,heightChanges
src/som/types.rs: AddIframevariant toElementRolesrc/som/compiler.rs: Detect iframes and extract attributessrc/cdp/domains.rs,src/cdp/session.rs: Handle new role in CDP mappingstests/: Add iframe detection and attribute testsExample SOM output
{ "id": "e_iframe_123", "role": "iframe", "attrs": { "src": "https://embed.example.com", "sandbox": "allow-scripts", "width": "800", "height": "600" } }Test plan
cargo test --test som_compiler_test iframe- 3 tests passcargo test --workspace- all 252+ tests passGenerated with Claude Code