ci: exclude test projects from the no-docs count - #3295
Merged
Conversation
The count-no-docs gate counts CS1591/CS1573 across the whole solution, including test projects (e.g. ~2900 from .Lib9c.Tests). Because check-items-without-docs-increased compares base vs head, this forces every PR that adds a public test class/constructor/[Fact] method to also add XML doc comments to them, which is noise — test methods are not public API. Filter out warnings attributed to a `*.Tests.csproj` before counting so the gate only tracks documentation coverage of the shippable projects. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ipdae
added a commit
that referenced
this pull request
Jul 2, 2026
ArenaCharacter.SetRuneSkills clamped rune skill power to int.MaxValue via SafeDecimalToInt32, while the PvE Player.SetRuneSkills fix widened it to long. For a high-stat caster this made PvE and arena compute different rune skill power (PvE full value, arena capped at ~2.1B). Widen the active arena SetRuneSkills to long/SafeDecimalToInt64 as well so both paths agree and match the long-based damage pipeline. The obsolete ArenaCharacter.SetRuneV1 is left unchanged for historical determinism. Add an arena regression test alongside the PvE one, and drop the per-member XML doc comments on the test (no longer needed now that the count-no-docs gate excludes test projects, #3295). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3294. The
count-no-docsgate countsCS1591/CS1573across the whole solution, including test projects (~2,900 warnings come from.Lib9c.Testsalone). Becausecheck-items-without-docs-increasedcompares base vs head counts, this forces every PR that adds a public test class / constructor /[Fact]method to also add XML doc comments to them — pure noise, since test methods are not shippable API.Change
Filter out warnings attributed to a
*.Tests.csprojbefore counting, so the gate only tracks documentation coverage of the shippable projects:Applied to both
count-no-docs-on-baserefandcount-no-docs-on-headref.Verification (local)
*.Tests.csproj: 8,206 (the 2,947 excluded are all attributed to test projects)0safely (guarded by|| true).CI only — no application code changed.
🤖 Generated with Claude Code