Skip to content

pkp/pkp-lib#13084: Use default error template to show 404 error messages #13087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NateWr wants to merge 1 commit into
base: stable-3_5_0
Choose a base branch
from
Open

pkp/pkp-lib#13084: Use default error template to show 404 error messages #13087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions classes/core/PKPApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
use PKP\site\Version;
use PKP\site\VersionDAO;
use PKP\submission\RepresentationDAOInterface;
use TemplateManager;

interface iPKPApplicationInfoProvider
{
Expand Down Expand Up @@ -435,8 +436,13 @@ public function execute(): void
}
} catch (\Symfony\Component\HttpKernel\Exception\NotFoundHttpException) {
header('HTTP/1.0 404 Not Found');
echo "<h1>404 Not Found</h1>\n";
exit;
$templateMgr = TemplateManager::getManager($this->getRequest());
$templateMgr->assign([
'pageTitle' => 'api.404.resourceNotFound',
'errorMsg' => '',
'errorParams' => [],
]);
$templateMgr->display('frontend/pages/error.tpl');
} catch (\Symfony\Component\HttpKernel\Exception\GoneHttpException) {
header('HTTP/1.0 410 Gone');
echo "<h1>404 Not Found</h1>\n";
Expand Down
2 changes: 1 addition & 1 deletion pages/management/ManagementHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ public function editUser(array $args, $request): void
$invitationHandler = $invitation->getInvitationUIActionRedirectController();
$invitationHandler->createHandle($request,$userId);
} else {
$request->getDispatcher()->handle404();
throw new \Symfony\Component\HttpKernel\Exception\NotFoundHttpException();

@NateWr NateWr Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check this change. I believe it is correct.

}
}

Expand Down