[OJS][stable-3_5_0] pkp/pkp-lib#12811 Use search landmark for the frontend search form - #5690
Open
thisismyurl wants to merge 1 commit into
Open
[OJS][stable-3_5_0] pkp/pkp-lib#12811 Use search landmark for the frontend search form#5690thisismyurl wants to merge 1 commit into
thisismyurl wants to merge 1 commit into
Conversation
The search form on the frontend search page carried `role="form"`, which exposes it as a generic (and, without an accessible name, unnamed) form landmark. Screen readers offer dedicated navigation for search regions, so the form is now exposed as a search landmark instead. `role="search"` is applied to the existing `<form>` element rather than introducing a `<search>` wrapper, which keeps the change to one attribute and preserves the existing label/input/submit associations. This is the same change as the main-branch PR, applied to the 3.5 LTS branch at the maintainer's request. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
|
There was a problem hiding this comment.
Pull request overview
Backports the accessibility fix from pkp/pkp-lib#12811 to the stable-3_5_0 branch by updating the frontend search page template so assistive technologies expose the page’s search form as a search landmark.
Changes:
- Update the search page
<form>landmark fromrole="form"torole="search"intemplates/frontend/pages/search.tpl.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses pkp/pkp-lib#12811 on the 3.5 LTS branch.
Companion to #5689 (the same fix on
main). Opening both at the maintainer's request: pkp/pkp-lib#12811 (comment) — israelcefrin asked to fix LTS and the current working branch, since the defect is live in both.What changed
templates/frontend/pages/search.tplcarriedrole="form"on the search form. This changes it torole="search"so assistive technology exposes it as a search landmark. A<form>with no accessible name (this one has none) exposes no form landmark at all, so this goes from no landmark to a search landmark, not a lateral swap.One attribute, one line. Identical to #5689.
Scope
<form>on the page; the tworole="status"occurrences elsewhere are the results/no-results live regions, untouched.<a>link, not a form, and isn't rendered on the search page, so this page exposes exactly one search landmark.Testing
Verified by reading the template source. I do not have an OJS instance running, so I have not repeated the screen-reader landmark check described in the issue.
Refs pkp/pkp-lib#12811
Prepared with AI assistance (Claude). I reviewed the template, confirmed the single call site, and checked the change against the issue's requirements.