Skip to content

fix: make location icon functional in Connect With Me section #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kritikaat
Copy link

@kritikaat kritikaat commented May 31, 2025

What does this PR do?

This pull request includes a fix for the issue where the Google Maps link and location text were not displaying or working correctly in the contact section.
Motivation: Ensure both the icon and text are properly clickable and open Google Maps in a new tab, improving the user experience.

Fixes #1935

_Piyush.Garg.-.Dev.and.Instructor.-.Personal.-.Microsoft_.Edge.2025-05-31.12-09-26.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to home in contact me section
  • Check that clicking the location icon and text opens Google Maps in a new tab.
  • Verify that the hover effects (e.g., color change) apply correctly to the location text.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented May 31, 2025

@kritikaat is attempting to deploy a commit to the Piyush Garg's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the bug Something isn't working label May 31, 2025
@kritikaat kritikaat changed the title made location icon on connect with me function by adding google map make location icon functional in Connect With Me section May 31, 2025
@kritikaat kritikaat changed the title make location icon functional in Connect With Me section make location icon functional in Connect With Me section May 31, 2025
@kritikaat kritikaat changed the title make location icon functional in Connect With Me section fix: make location icon functional in Connect With Me section May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Location icon in "Connect with me" section is non-functional - consider linking or removing
1 participant