chore(contracts): safe migration scripts #548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
requested review from
LeoHChen,
jdubpark,
edisonz0718,
gezerui0124,
limengformal,
0xHansLee and
ramtinms
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Spablob
reviewed
May 21, 2025
contracts/script/admin-actions/migrate-to-safe/4.RenounceGovernanceRoles.s.sol
Show resolved
Hide resolved
Ramarti
force-pushed
the
gov/safe-migration
branch
from
df8dd1f to
cf3f089
Compare
Ramarti
force-pushed
the
gov/safe-migration
branch
from
cf3f089 to
4d38ae4
Compare
|
@Ramarti is this PR still relevant? |
Ramarti
force-pushed
the
gov/safe-migration
branch
from
4d38ae4 to
c66042d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of helper contracts, TimelockJSONTxWriter helps generate encoded batched tx JSON files for signers to verify and to be proposed to multisig.
See the README file for explanation on the scripts
Unit tests for all the migration script outputs here:
https://github.com/piplabs/story/tree/7e14fcbc779a8bc81c41596703cfc699b7f24f6a/contracts/test/safe-migration
issue: none