Skip to content

fix(cli): report version on abci info endpoint #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(cli): report version on abci info endpoint #546

wants to merge 3 commits into from

Conversation

DavidVentura
Copy link

@DavidVentura DavidVentura commented May 14, 2025 •
edited
Loading

populate the version field on the abci-info endpoint

issue: #497

@codecov Codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
client/app/app.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@0xHansLee
Copy link
Contributor

Thanks for your contribution! Could you change the description? The allowed format of issue is like issue: #<issue_num>.

@DavidVentura
Copy link
Author

updated

@0xHansLee
Copy link
Contributor

_ is not allowed in description, so could you edit once again? Thanks

@DavidVentura
Copy link
Author

DavidVentura commented May 21, 2025 •
edited
Loading

okay, updated to match ^[a-z0-9 .&/-]+$, ` was also not allowed

@0xHansLee 0xHansLee changed the title fix(cli): report version on abci_info endpoint fix(cli): report version on abci info endpoint Jun 2, 2025
@qezz
Copy link

qezz commented Jul 8, 2025

Hey team. May I ask you if there are any blockers on this patch?

@ramtinms
Copy link

@0xHansLee and @stevemilk please merge this PR and prepare forrelease if no objection

@0xHansLee
Copy link
Contributor

Sorry for the delay. Let me merge this PR after release v1.3.1 which is released soon.

@0xHansLee
Copy link
Contributor

@DavidVentura While updating this branch onto main (5ece358), the commit loses verified signatures. Could you make the signature and push again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramtinms ramtinms ramtinms approved these changes

@stevemilk stevemilk stevemilk approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@jdubpark jdubpark Awaiting requested review from jdubpark jdubpark is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@gezerui0124 gezerui0124 Awaiting requested review from gezerui0124 gezerui0124 is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DavidVentura @0xHansLee @qezz @ramtinms @stevemilk