-
-
Notifications
You must be signed in to change notification settings - Fork 399
Feat/ship market show details #6191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/ship market show details #6191
Conversation
|
A little tested and it looks fine so far, thank you, mwerle! What i have not mentioned: The Capacity shown in the left half of the screen is still the capacity for the equipment, expected is the Cargo space. I Recommend to split the Ship market window in a 1:2 ratio and to show on the left side only symbol, name and list price of the ship, so there is more space for details on the right side, as cargo capacity may not be of interest for fighters. (maybe 3 columns for details? for wider/16:9 allover game resolution?) For refactor equipment, see #6161 |
|
Regarding slots, I'd suggest it might be better to display the list of slots directly (using e.g. the display from the info view / outfitter), rather than trying to categorize them at such granularity.
Correct - this diversity is entirely intended. The sensor slot is reserved for the primary flight+fire-control radar/lidar sensors (which will be customizable by the player when sensor gameplay is implemented), while target/hypercloud scanners are a fusion of a standalone sensor aperture and a separate computer system. The use of utility hardpoints is intended to be the primary "meaningful choice" with such equipment; you can mount a target scanner, you can mount a hypercloud analyzer, but if you do both you might not have enough hardpoints left to mount another piece of utility equipment you actually want to use. |
Sorry, I had a look, and I don't see what you mean. The info view shows practically nothing slot-related. The equipment outfitter view has various slot types grouped together in categories and is even more granular within those categories than what I've done so far. If you could give a slightly more detailed example of what you envision here that would be much appreciated. |
ab696ca to
fcb037b
Compare
From a combat perspective, scanning the default missile bay equipment (I believe most missile bay mounts are marked up with a default equipment item) for individual missile mounts is more helpful/useful than displaying the number of missile bays (e.g. display 20 missile mounts rather than/in addition to 4 bays). Neither fully capture the nuance of missile sizing, but the layout of the screen is archaic enough that there's no way to cram that kind of detail into this list. |
The logic in the ShipMarket display invoked the "SlotTypeMatches" function with inverted parameters, leading to incorrect results when matching slot patterns. For example, searching for "missile_bay" slots fails to return any, because they are all specialised such as "missile_bay.opli_internal". With the correct parameter order the correct number is returned.
Show all the different slots/mounts which a ship has to give a potential buyer a better understanding of the difference between the ship they currently have and the one they are considering to buy. Fixes pioneerspacesim#6183 TODO: Also display the actual equipment currently installed on the ship.
fcb037b to
f09a95f
Compare


DRAFT PR - discuss details
TODO:
DISCUSS:
Fixes #6183
The ShipMarket does not display all the statistic about the ships, specifically, the different slots available on each ship.
This PR adds (most of?) the different slots to the ship comparison display.