Skip to content

Conversation

@raymondtieu
Copy link

@raymondtieu raymondtieu commented Jul 10, 2025

SUMMARY

  • Removed the RBAC feature flag and user type checks in when checking canUserSaveAsDashboard permissions
  • Allow all users to use the "Save as" menu option in a dashboard

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  • Open a dashboard as a non-admin and non-owner, "Save as" should be available on every dashboard

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@raymondtieu raymondtieu changed the base branch from master to pinterest-release-4.1.1 July 10, 2025 14:30
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@raymondtieu raymondtieu marked this pull request as ready for review July 11, 2025 21:43
@raymondtieu raymondtieu merged commit 40d2c13 into pinterest:pinterest-release-4.1.1 Jul 11, 2025
31 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants