Skip to content

Conversation

@kgopal492
Copy link
Collaborator

SUMMARY

  • Check if user is already logged in, before logging anonymous user for embedding
  • Use user roles, rather than user id to filter view menu permissions (since anonymous users don't have user ids)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (pinterest-release-4.1.1@5204b5e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
superset/views/dashboard/views.py 0.00% 2 Missing ⚠️
superset/embedded/view.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             pinterest-release-4.1.1      #53   +/-   ##
==========================================================
  Coverage                           ?   83.56%           
==========================================================
  Files                              ?      539           
  Lines                              ?    38673           
  Branches                           ?        0           
==========================================================
  Hits                               ?    32317           
  Misses                             ?     6356           
  Partials                           ?        0           
Flag Coverage Δ
hive 48.93% <20.00%> (?)
postgres 76.77% <40.00%> (?)
presto 53.42% <20.00%> (?)
python 83.56% <40.00%> (?)
sqlite 76.24% <40.00%> (?)
unit 60.39% <20.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kgopal492 kgopal492 merged commit 0aa3bfa into pinterest:pinterest-release-4.1.1 Mar 31, 2025
18 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants