fix(server): find project icons inside monorepo workspace packages

[mackinleysmith]

Problem

Project favicons are resolved by checking a fixed list of paths relative to the project root (favicon.ico, public/favicon.*, app/favicon.ico, src/app/icon.*, …). A monorepo root almost never has any of those — the icon lives inside a workspace package. A Turborepo whose web app sits at apps/frontend shows the generic fallback icon even though apps/frontend/app/favicon.ico exists.

Setting iconPath in t3.json works around it, but it shouldn't be needed for the standard layout.

Fix

When the root scan comes up empty, ProjectFaviconResolver re-checks the same well-known icon locations and <link rel="icon"> source files inside each apps/* and packages/* directory.

Most of the diff is moving the existing root scan into a findIconWithin(projectCwd, packageDir) helper that takes a package directory prefix; the new logic is one directory listing and the loop that calls it.

• The root is checked first and t3.json iconPath still wins over everything, so single-package projects are unchanged.
• apps/* is scanned before packages/*, children sorted, so the result is deterministic.
• A missing apps/ or packages/ directory is skipped. Other filesystem failures surface as ProjectFaviconResolutionError (list-packages), matching how candidate stats are already handled rather than silently reporting "no icon".

This deliberately keys off the apps//packages/ convention rather than parsing pnpm-workspace.yaml or package.json workspace globs. That covers the layout Turborepo scaffolds and nearly everyone uses, without a glob engine in the resolver. A project with a custom layout still has t3.json iconPath.

No UI change beyond the icon itself now resolving, so there's nothing meaningful to screenshot.

Testing

vp test run src/project/ProjectFaviconResolver.test.ts src/assets/AssetAccess.test.ts — 25 passed. Five new cases cover a package favicon file, package-level <link rel="icon"> resolution, root precedence, apps-before-packages ordering, and a propagated listing failure.

Also ran the resolver against a real Turborepo: it now returns apps/frontend/app/favicon.ico instead of null, and this repo still resolves via its own t3.json iconPath.

Model: Claude Opus 5. Harness: T3 Code.

Note

Fix project icon resolution to search inside monorepo workspace packages

• ProjectFaviconResolver.resolvePath now searches apps/* and packages/* workspace directories for icons when no icon is found at the repo root.
• Adds findIconWithin to scope icon discovery (favicon candidates and <link rel="icon"> hrefs in source files) to a single directory, and findPackageDirectories to enumerate workspace package dirs.
• Root-level icons take precedence over workspace package icons; among packages, apps/ is checked before packages/, with subdirectories sorted alphabetically.
• Non-NotFound filesystem errors during package directory listing are surfaced as ProjectFaviconResolutionError with the new list-packages operation.

^{Macroscope summarized a6229a9.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c3abce29-54ab-42a6-a14d-b195c7ca1fdc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit f794a2d. Configure here.}

[cursor]

Negated globs block pnpm re-inclusions

Medium Severity

In findWorkspacePackages, negated workspace globs add paths to excluded, and the final pass drops any package in that set. pnpm allows a later positive glob to re-include a package after a broad negation (for example !packages/* then packages/web). Those re-included packages stay in excluded, so they are never scanned for icons and favicon resolution can miss the only valid icon.

 

^{Reviewed by Cursor Bugbot for commit f794a2d. Configure here.}

[mackinleysmith]

Fixed by removal in a6229a9 — the analysis was correct.

pnpm re-inclusion after a broad negation (!packages/* then packages/web) was genuinely mishandled: excluded was a one-way set with no re-inclusion path.

Rather than fix the ordering, the PR no longer parses workspace globs at all. It scans the apps/* and packages/* convention directly, so negation semantics are out of scope. Projects with a custom layout can still point at an icon with iconPath in t3.json.

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new monorepo favicon discovery capability, searching workspace packages when icons aren't found at the root. While well-tested and relatively low-risk, this introduces new runtime behavior beyond a simple bug fix. The open review comment references code not present in this PR.

^{You can customize Macroscope's approvability policy. Learn more.}