Skip to content

fix(web): keep release notes tooltip open on hover #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyleKincer wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

fix(web): keep release notes tooltip open on hover #5337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/web/src/components/sidebar/SidebarUpdatePill.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { describe, expect, it } from "vite-plus/test";

import { NIGHTLY_RELEASE_NOTES_TOOLTIP_CLASS_NAME } from "./SidebarUpdatePill";

describe("nightly release notes tooltip", () => {
it("keeps the whole popup hoverable while moving from the update pill", () => {
expect(NIGHTLY_RELEASE_NOTES_TOOLTIP_CLASS_NAME).toContain("pointer-events-auto");
});
});
7 changes: 5 additions & 2 deletions apps/web/src/components/sidebar/SidebarUpdatePill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ import { Alert, AlertDescription, AlertTitle } from "../ui/alert";
import { Separator } from "../ui/separator";
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";

export const NIGHTLY_RELEASE_NOTES_TOOLTIP_CLASS_NAME =
"pointer-events-auto max-w-none text-balance";

function SidebarUpdateReleaseNotesTooltip({
state,
tooltip,
Expand All @@ -35,7 +38,7 @@ function SidebarUpdateReleaseNotesTooltip({
<div className="px-1">
<div className="text-sm leading-5 font-medium">{tooltip}</div>
</div>
<div className="pointer-events-auto max-h-[min(28rem,calc(100vh-6rem))] overflow-y-auto px-1 pt-4 pb-1">
<div className="max-h-[min(28rem,calc(100vh-6rem))] overflow-y-auto px-1 pt-4 pb-1">
{state.releaseNotes.map((releaseNote, index) => (
<div key={releaseNote.version}>
{index > 0 && <Separator className="my-3 bg-border/60" />}
Expand Down Expand Up @@ -194,7 +197,7 @@ export function SidebarUpdatePill() {
align="start"
className={
state?.channel === "nightly" && state.releaseNotes.length > 0
? "max-w-none text-balance"
? NIGHTLY_RELEASE_NOTES_TOOLTIP_CLASS_NAME
: undefined
}
side="top"
Expand Down
Loading