Avoid extra terminal drawer render when opening#4158
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Opening the terminal drawer updated
resizeEpochafter the initial visible render, causing an avoidable secondThreadTerminalDrawercommit. A clean React Scan run now records one drawer commit while the terminal still fits and resizes correctly.UI Changes
No visual change. The terminal drawer opens and focuses as before, with one committed drawer render instead of two. Diagnostic React Scan recording used a temporary overlay that was removed before submission.
Checklist
Note
Prevent
TerminalViewportfrom fitting and resizing while the terminal drawer is hiddenPreviously, a
useEffectinThreadTerminalDrawerbumpedresizeEpochon visibility changes, triggering resize operations even when the terminal was hidden. Now,TerminalViewportaccepts avisibleprop and skips fit/scroll/resize operations whenfalse, re-running them when visibility changes totrue.Macroscope summarized 7c87dec. (Automatic summaries will resume when PR exits draft mode or review begins).