model: add minimal info for active-active table #64512
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @xhebox. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64512 +/- ##
================================================
+ Coverage 72.6837% 73.1520% +0.4683%
================================================
Files 1866 1866
Lines 506409 506505 +96
================================================
+ Hits 368077 370519 +2442
+ Misses 115953 113713 -2240
+ Partials 22379 22273 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
| TTLInfo *TTLInfo `json:"ttl_info"` | ||
|
|
||
| // IsActiveActive means the table is active-active table. | ||
| IsActiveActive bool `json:"is_active_active"` |
There was a problem hiding this comment.
Do we also need to introduce ActiveActiveInfo for further extension ?
There was a problem hiding this comment.
Do we have any other info to store like TTL? I did not see that in the spec..
There was a problem hiding this comment.
If SoftdeleteInfo != nil can be used to replace IsActiveActive, is it possible to remove IsActiveActive?
There was a problem hiding this comment.
soft delete and active-active are two standalone features. I think these flags should be separate.
There was a problem hiding this comment.
Well. From this PR description, it's not clear that these are two separate functions. Moreover, there is no call to these variables in the implementation. So, I would like to ask about this.
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lcwangchao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@xhebox: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@xhebox: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
What problem does this PR solve?
Issue Number: ref #64281
Problem Summary: This should be in the feature branch. But due to how TiCDC organized, it needs to be in the master. No real code here, just definition of
TableInfo.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.