Skip to content

Conversation

@xhebox
Copy link
Contributor

@xhebox xhebox commented Nov 17, 2025

What problem does this PR solve?

Issue Number: ref #64281

Problem Summary: This should be in the feature branch. But due to how TiCDC organized, it needs to be in the master. No real code here, just definition of TableInfo.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 17, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 17, 2025
@tiprow
Copy link

tiprow bot commented Nov 17, 2025

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xhebox xhebox mentioned this pull request Nov 17, 2025
41 tasks
@xhebox
Copy link
Contributor Author

xhebox commented Nov 17, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 17, 2025
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.1395%. Comparing base (e10a603) to head (b1ce848).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64512        +/-   ##
================================================
+ Coverage   72.6816%   73.1395%   +0.4578%     
================================================
  Files          1866       1866                
  Lines        506282     506383       +101     
================================================
+ Hits         367974     370366      +2392     
+ Misses       115918     113731      -2187     
+ Partials      22390      22286       -104     
Flag Coverage Δ
integration 41.9083% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.1686% <ø> (+0.0075%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: xhe <[email protected]>
@xhebox
Copy link
Contributor Author

xhebox commented Nov 17, 2025

/retest

@tiprow
Copy link

tiprow bot commented Nov 17, 2025

@xhebox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow b1ce848 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2025

@xhebox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 b1ce848 link true /test pull-unit-test-ddlv1
pull-unit-test-next-gen b1ce848 link true /test pull-unit-test-next-gen
idc-jenkins-ci-tidb/unit-test b1ce848 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


// SoftdeleteInfo records the Softdelete config.
type SoftdeleteInfo struct {
Enable bool `json:"enable"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it means ClienJobEnabled ?

TTLInfo *TTLInfo `json:"ttl_info"`

// IsActiveActive means the table is active-active table.
IsActiveActive bool `json:"is_active_active"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to introduce ActiveActiveInfo for further extension ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants