-
Notifications
You must be signed in to change notification settings - Fork 6.1k
model: add minimal info for active-active table #64512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: xhe <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @xhebox. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64512 +/- ##
================================================
+ Coverage 72.6816% 73.1395% +0.4578%
================================================
Files 1866 1866
Lines 506282 506383 +101
================================================
+ Hits 367974 370366 +2392
+ Misses 115918 113731 -2187
+ Partials 22390 22286 -104
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: xhe <[email protected]>
|
/retest |
|
@xhebox: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@xhebox: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| // SoftdeleteInfo records the Softdelete config. | ||
| type SoftdeleteInfo struct { | ||
| Enable bool `json:"enable"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it means ClienJobEnabled ?
| TTLInfo *TTLInfo `json:"ttl_info"` | ||
|
|
||
| // IsActiveActive means the table is active-active table. | ||
| IsActiveActive bool `json:"is_active_active"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to introduce ActiveActiveInfo for further extension ?
What problem does this PR solve?
Issue Number: ref #64281
Problem Summary: This should be in the feature branch. But due to how TiCDC organized, it needs to be in the master. No real code here, just definition of
TableInfo.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.