Skip to content

Conversation

@lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Nov 14, 2025

What problem does this PR solve?

Issue Number: close #64485

What changed and how does it work?

Add some metrics for index lookup push down:

image
  • IndexLookUp OPS The OPS of IndexLookUp, it contains the index-lookup-pushdown OPS for both executor and tasks.
  • IndexLookUp Duration The IndexLookUpExecutor duration if push down is enabled
  • IndexLookUp Rows The hint and miss rows for index lookup pushdown
  • IndexLookUp PushDown Row Num The bucket of query rows in each IndexLookUpExecutor if push down is enabled

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.4259%. Comparing base (bd6aa86) to head (a37d39f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64487        +/-   ##
================================================
+ Coverage   72.6891%   73.4259%   +0.7368%     
================================================
  Files          1866       1867         +1     
  Lines        506286     506769       +483     
================================================
+ Hits         368015     372100      +4085     
+ Misses       115899     112486      -3413     
+ Partials      22372      22183       -189     
Flag Coverage Δ
integration 41.8092% <92.3076%> (?)
unit 72.5678% <100.0000%> (+0.3049%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (+0.1132%) ⬆️
parser ∅ <ø> (∅)
br 46.2438% <ø> (+0.0676%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lcwangchao
Copy link
Collaborator Author

/retest

@lcwangchao lcwangchao force-pushed the metrics_indexlookuppushdown branch from 4b8e099 to 8a8c0e9 Compare November 17, 2025 06:39
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 17, 2025
@lcwangchao lcwangchao force-pushed the metrics_indexlookuppushdown branch 2 times, most recently from 1bb9f4b to dbce340 Compare November 17, 2025 07:51
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 17, 2025
@lcwangchao lcwangchao force-pushed the metrics_indexlookuppushdown branch from dbce340 to a37d39f Compare November 17, 2025 09:02
@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cfzjywxk, you06
Once this PR has been reviewed and has the lgtm label, please assign zimulala for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-17 08:47:40.30021847 +0000 UTC m=+1296709.743248359: ☑️ agreed by cfzjywxk.
  • 2025-11-17 10:04:01.570409598 +0000 UTC m=+1301291.013439477: ☑️ agreed by you06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add metrics for index lookup push-down

3 participants