Skip to content

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Sep 28, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2025
Copy link

tiprow bot commented Sep 28, 2025

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Leavrth
Leavrth previously approved these changes Sep 28, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 28, 2025
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5-20250114-v8.5.0@3741f27). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.5-20250114-v8.5.0     #63786   +/-   ##
================================================================
  Coverage                               ?   57.8271%           
================================================================
  Files                                  ?       1789           
  Lines                                  ?     634932           
  Branches                               ?          0           
================================================================
  Hits                                   ?     367163           
  Misses                                 ?     242401           
  Partials                               ?      25368           
Flag Coverage Δ
integration 38.5204% <46.4285%> (?)
unit 72.0821% <96.4285%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.6904% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lance6716
Copy link
Contributor

/retest

Copy link

tiprow bot commented Sep 28, 2025

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

err := utils.WithRetry(ctx, func() error {
return client.Put(ctx, key, value, originTs)
}, utils.NewRawClientBackoffStrategy())
if err != nil {
Copy link
Contributor

@lance6716 lance6716 Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to print the error to know the root cause? maybe next time it's not the "idle" error and we need to locate and fix it

YuJuncen
YuJuncen previously approved these changes Sep 29, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2025
Copy link

ti-chi-bot bot commented Sep 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-28 07:36:23.052342648 +0000 UTC m=+774193.122836330: ☑️ agreed by Leavrth.
  • 2025-09-29 06:28:20.249629566 +0000 UTC m=+66080.506360976: ☑️ agreed by YuJuncen.

@RidRisR
Copy link
Contributor Author

RidRisR commented Sep 30, 2025

/retest

Copy link

tiprow bot commented Sep 30, 2025

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RidRisR RidRisR changed the title br: got rpcClient is idle error during log meta restore br: got rpcClient is idle error during log meta restore| tidb-test=release-8.5.1 Sep 30, 2025
@RidRisR
Copy link
Contributor Author

RidRisR commented Sep 30, 2025

/retest

Copy link

tiprow bot commented Sep 30, 2025

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RidRisR RidRisR changed the title br: got rpcClient is idle error during log meta restore| tidb-test=release-8.5.1 br: got rpcClient is idle error during log meta restore| tidb-test=release-8.5-20250114-v8.5.0 Sep 30, 2025
@RidRisR
Copy link
Contributor Author

RidRisR commented Sep 30, 2025

/retest

Copy link

tiprow bot commented Sep 30, 2025

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RidRisR RidRisR dismissed stale reviews from YuJuncen and Leavrth via 4205316 September 30, 2025 10:09
Copy link

ti-chi-bot bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3pointer, benjamin2037 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. and removed approved labels Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants