cdc: remove enable_old_value field (#21210) #21645
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
area/ticdc
|
@wlwilliamx This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the TiCDC documentation by removing references to the "enable_old_value" field. This field was deprecated in TiDB v7.4.0, and its removal from the documentation ensures that the guides and API specifications reflect the current state of the product, preventing users from configuring a deprecated option.
Highlights
- Documentation cleanup: Removed the deprecated "enable_old_value" field from various TiCDC documentation files.
- Example consistency: Updated example JSON configurations and command outputs across multiple guides to no longer include the "enable_old_value" parameter.
- Version alignment: Ensures documentation aligns with the deprecation of "enable_old_value" in TiDB v7.4.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
size/S
There was a problem hiding this comment.
Code Review
This pull request aims to remove the deprecated enable_old_value field from the TiCDC documentation. The changes in ticdc/ticdc-open-api-v2.md correctly remove the field from the API specification. However, three other files (ticdc/ticdc-changefeed-config.md, ticdc/ticdc-manage-changefeed.md, and ticdc/ticdc-sink-to-cloud-storage.md) contain unresolved merge conflicts in their example outputs. These conflicts need to be resolved to ensure the documentation is accurate and readable. I have provided suggestions to fix these conflicts.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ti-chi-bot
bot
added
size/XS
|
/approve |
qiancai
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #21210
First-time contributors' checklist
What is changed, added or deleted? (Required)
The enable_old_value field was deprecated in v7.4.0 and should be removed from the documentation.
For more details, see pingcap/tiflow#9224.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?