OWNERS: Auto Sync OWNERS files from community membership #21636
Conversation
[skip ci] Update OWNERS file skip-checks: true Signed-off-by: Ti Chi Robot <[email protected]>
[skip ci] Update OWNERS file skip-checks: true Signed-off-by: Ti Chi Robot <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request automates the synchronization of OWNERS files by transitioning from explicit individual listings to referencing community membership groups. The change centralizes the management of approvers and reviewers by defining these groups in OWNERS_ALIASES and indicating that these memberships are synced from the pingcap/community repository. This enhances maintainability and ensures that ownership information remains up-to-date with community changes.
Highlights
- Streamlined OWNERS file: The
OWNERSfile has been refactored to no longer list individual approvers and reviewers directly. Instead, it now references group aliases, specificallysig-community-approversandsig-community-reviewers. - Centralized group definitions: The
OWNERS_ALIASESfile has been updated to define the newsig-community-approversandsig-community-reviewersaliases. These aliases now contain the comprehensive list of individual members who were previously hardcoded in theOWNERSfile. - Improved documentation and sync clarity: New comments have been added to both
OWNERSandOWNERS_ALIASESfiles, clarifying that the listed community memberships are automatically synced from thepingcap/communityrepository. This improves transparency and maintainability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
the
size/M
|
/release-note-none |
ti-chi-bot
added
approved
lgtm
skip-issue-check
ti-chi-bot
bot
removed
the
missing-translation-status
There was a problem hiding this comment.
Code Review
This pull request refactors the OWNERS file to use aliases from OWNERS_ALIASES, which centralizes the management of approvers and reviewers. This is a good improvement for maintainability. My review includes a couple of minor suggestions to sort the new member lists in OWNERS_ALIASES alphabetically to further improve readability and ease of maintenance.
| - 3pointer | ||
| - GMHDBJD | ||
| - Joyinqin | ||
| - KanShiori | ||
| - Yisaer | ||
| - amyangfei | ||
| - anotherrachel | ||
| - aylei | ||
| - crazycs520 | ||
| - dveeden | ||
| - ericsyh | ||
| - glkappe | ||
| - junlan-zhang | ||
| - lucklove | ||
| - lysu | ||
| - ngaut | ||
| - superlzs0476 | ||
| - tiancaiamao | ||
| - weekface | ||
| - zimulala |
There was a problem hiding this comment.
For better readability and easier maintenance, please consider sorting the list of reviewers alphabetically.
- 3pointer
- amyangfei
- anotherrachel
- aylei
- crazycs520
- dveeden
- ericsyh
- glkappe
- GMHDBJD
- Joyinqin
- junlan-zhang
- KanShiori
- lucklove
- lysu
- ngaut
- superlzs0476
- tiancaiamao
- weekface
- Yisaer
- zimulala
| - Icemap | ||
| - Oreoxmt | ||
| - breezewish | ||
| - csuzhangxc | ||
| - hfxsd | ||
| - jackysp | ||
| - kissmydb | ||
| - lance6716 | ||
| - lilin90 | ||
| - overvenus | ||
| - qiancai | ||
| - tangenta |
There was a problem hiding this comment.
For better readability and easier maintenance, please consider sorting the list of approvers alphabetically.
- breezewish
- csuzhangxc
- hfxsd
- Icemap
- jackysp
- kissmydb
- lance6716
- lilin90
- Oreoxmt
- overvenus
- qiancai
- tangenta
Check List
Tests